Re: [ovs-dev] [PATCH] stuck with 16-bit ifr_flags in FreeBSD

2015-04-05 Thread Ben Pfaff
On Sun, Apr 05, 2015 at 01:01:17AM +0800, Kevin Lo wrote: > On Fri, Apr 03, 2015 at 03:15:00PM -0700, Ben Pfaff wrote: > > Kevin, if my understanding of this as a sign extension bug is correct, > > please update the commit message and I'll apply this to master (and > > backport to earlier versions)

Re: [ovs-dev] [PATCH] stuck with 16-bit ifr_flags in FreeBSD

2015-04-05 Thread Kevin Lo
On Sat, Apr 04, 2015 at 10:35:07PM -0400, Ed Maste wrote: > > On 4 April 2015 at 12:56, Kevin Lo wrote: > >> Kevin, what failure mode did you observe? > > > > On FreeBSD, multicast is enabled on the interface by default, the value of > > ifr_flags could be negative if multicast is enabled. > > R

Re: [ovs-dev] [PATCH] stuck with 16-bit ifr_flags in FreeBSD

2015-04-04 Thread Ed Maste
On 4 April 2015 at 12:56, Kevin Lo wrote: >> Kevin, what failure mode did you observe? > > On FreeBSD, multicast is enabled on the interface by default, the value of > ifr_flags could be negative if multicast is enabled. Right, but what actually happens in this case? The sign extension bug means

Re: [ovs-dev] [PATCH] stuck with 16-bit ifr_flags in FreeBSD

2015-04-04 Thread Kevin Lo
On Fri, Apr 03, 2015 at 03:15:00PM -0700, Ben Pfaff wrote: > > On Fri, Apr 03, 2015 at 02:46:11PM -0400, Ed Maste wrote: > > On 3 April 2015 at 13:46, Ben Pfaff wrote: > > > > > >> > Also, the commit you name was in 2013, and we've had other > > >> > contributions from FreeBSD contributors since

Re: [ovs-dev] [PATCH] stuck with 16-bit ifr_flags in FreeBSD

2015-04-04 Thread Kevin Lo
On Fri, Apr 03, 2015 at 02:46:11PM -0400, Ed Maste wrote: > > On 3 April 2015 at 13:46, Ben Pfaff wrote: > > > >> > Also, the commit you name was in 2013, and we've had other > >> > contributions from FreeBSD contributors since then > >> > (namely Ed Maste ) and it seems like he > >> > would have

Re: [ovs-dev] [PATCH] stuck with 16-bit ifr_flags in FreeBSD

2015-04-03 Thread Ben Pfaff
On Fri, Apr 03, 2015 at 02:46:11PM -0400, Ed Maste wrote: > On 3 April 2015 at 13:46, Ben Pfaff wrote: > > > >> > Also, the commit you name was in 2013, and we've had other > >> > contributions from FreeBSD contributors since then > >> > (namely Ed Maste ) and it seems like he > >> > would have no

Re: [ovs-dev] [PATCH] stuck with 16-bit ifr_flags in FreeBSD

2015-04-03 Thread Ed Maste
On 3 April 2015 at 13:46, Ben Pfaff wrote: > >> > Also, the commit you name was in 2013, and we've had other >> > contributions from FreeBSD contributors since then >> > (namely Ed Maste ) and it seems like he >> > would have noticed if it were totally busted. >> >> You mean this message: >> http:

Re: [ovs-dev] [PATCH] stuck with 16-bit ifr_flags in FreeBSD

2015-04-03 Thread Ben Pfaff
On Sat, Apr 04, 2015 at 12:10:30AM +0800, Kevin Lo wrote: > On Fri, Apr 03, 2015 at 08:16:18AM -0700, Ben Pfaff wrote: > > > > On Fri, Apr 03, 2015 at 10:02:16PM +0800, Kevin Lo wrote: > > > I'm attempting to install ovs 2.3.1 on FreeBSD and it appears to be broken > > > after the commit 666afb55e

Re: [ovs-dev] [PATCH] stuck with 16-bit ifr_flags in FreeBSD

2015-04-03 Thread Kevin Lo
On Fri, Apr 03, 2015 at 08:16:18AM -0700, Ben Pfaff wrote: > > On Fri, Apr 03, 2015 at 10:02:16PM +0800, Kevin Lo wrote: > > I'm attempting to install ovs 2.3.1 on FreeBSD and it appears to be broken > > after the commit 666afb55e84e9118812de81a75655ec9567b7a5b. > > Since FreeBSD uses two short in

Re: [ovs-dev] [PATCH] stuck with 16-bit ifr_flags in FreeBSD

2015-04-03 Thread Ben Pfaff
On Fri, Apr 03, 2015 at 10:02:16PM +0800, Kevin Lo wrote: > I'm attempting to install ovs 2.3.1 on FreeBSD and it appears to be broken > after the commit 666afb55e84e9118812de81a75655ec9567b7a5b. > Since FreeBSD uses two short integers to represent interface flags, > we have to apply mask 0x t