Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix a bug.

2014-04-25 Thread Alex Wang
On Fri, Apr 25, 2014 at 5:47 PM, Joe Stringer wrote: > Thanks for fixing this, Alex. I think there was a bit of mixup the last > time I rebased. > Np, actually, I will have another patch to add assert (!udpif->handlers && !udpif->revalidators) ___ dev m

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix a bug.

2014-04-25 Thread Joe Stringer
Thanks for fixing this, Alex. I think there was a bit of mixup the last time I rebased. On 26 April 2014 07:33, Alex Wang wrote: > Applied, thx a lot, > > Now, let's fix the build (unittest) issue~~~ > > > On Fri, Apr 25, 2014 at 11:31 AM, Gurucharan Shetty wrote: > >> On Fri, Apr 25, 2014 at 1

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix a bug.

2014-04-25 Thread Alex Wang
Applied, thx a lot, Now, let's fix the build (unittest) issue~~~ On Fri, Apr 25, 2014 at 11:31 AM, Gurucharan Shetty wrote: > On Fri, Apr 25, 2014 at 11:04 AM, Alex Wang wrote: > > Commit 7d170098 (ofproto-dpif-upcall: Remove the flow_dumper thread.) > > initialized the memory barrier inside t

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix a bug.

2014-04-25 Thread Gurucharan Shetty
On Fri, Apr 25, 2014 at 11:04 AM, Alex Wang wrote: > Commit 7d170098 (ofproto-dpif-upcall: Remove the flow_dumper thread.) > initialized the memory barrier inside the udpif_start_threads() function. > However, the udpif_start_threads() function does not check the number of > revalidator threads sp