Re: [ovs-dev] [PATCH] ofproto-dpif: keep slow path flow time stamp up-to-date

2013-12-02 Thread Andy Zhou
pushed to the master. Thanks, On Fri, Nov 22, 2013 at 6:28 PM, Ben Pfaff wrote: > That sounds great, thanks a lot. > > On Fri, Nov 22, 2013 at 05:06:11PM -0800, Andy Zhou wrote: > > Sure, I will test it more and wait for a bit before pushing, just in case > > Guolin has additional feedback. T

Re: [ovs-dev] [PATCH] ofproto-dpif: keep slow path flow time stamp up-to-date

2013-11-22 Thread Ben Pfaff
That sounds great, thanks a lot. On Fri, Nov 22, 2013 at 05:06:11PM -0800, Andy Zhou wrote: > Sure, I will test it more and wait for a bit before pushing, just in case > Guolin has additional feedback. Thanks for the review and redactor > suggestion. > > > On Fri, Nov 22, 2013 at 4:58 PM, Ben P

Re: [ovs-dev] [PATCH] ofproto-dpif: keep slow path flow time stamp up-to-date

2013-11-22 Thread Andy Zhou
Sure, I will test it more and wait for a bit before pushing, just in case Guolin has additional feedback. Thanks for the review and redactor suggestion. On Fri, Nov 22, 2013 at 4:58 PM, Ben Pfaff wrote: > Do you want to check it in then? > > On Fri, Nov 22, 2013 at 04:53:09PM -0800, Andy Zhou

Re: [ovs-dev] [PATCH] ofproto-dpif: keep slow path flow time stamp up-to-date

2013-11-22 Thread Ben Pfaff
Do you want to check it in then? On Fri, Nov 22, 2013 at 04:53:09PM -0800, Andy Zhou wrote: > Yes, this patch would eliminate code duplications. The logic looks right > to me. > > > On Fri, Nov 22, 2013 at 3:57 PM, Ben Pfaff wrote: > > > On Thu, Nov 21, 2013 at 08:45:22PM -0800, Andy Zhou wro

Re: [ovs-dev] [PATCH] ofproto-dpif: keep slow path flow time stamp up-to-date

2013-11-22 Thread Andy Zhou
Yes, this patch would eliminate code duplications. The logic looks right to me. On Fri, Nov 22, 2013 at 3:57 PM, Ben Pfaff wrote: > On Thu, Nov 21, 2013 at 08:45:22PM -0800, Andy Zhou wrote: > > Noting updating slow path subfacet's time stamp can cause their datapath > > flows deleted periodic

Re: [ovs-dev] [PATCH] ofproto-dpif: keep slow path flow time stamp up-to-date

2013-11-22 Thread Ben Pfaff
On Thu, Nov 21, 2013 at 08:45:22PM -0800, Andy Zhou wrote: > Noting updating slow path subfacet's time stamp can cause their datapath > flows deleted periodically. For example, CFM datapath flow have usespace > actions that are handled in dpif slow path. They are deleted and > recreated periodicall