Re: [ovs-dev] [PATCH] ofproto-dpif: Use DPIF_FP_CREATE but not DPIF_FP_MODIFY.

2014-08-06 Thread Ben Pfaff
I crossported this to branch-2.3. branch-2.3 has an unrelated bug that makes it unusable, though. I posted a fix: http://openvswitch.org/pipermail/dev/2014-August/043634.html On Mon, Aug 4, 2014 at 8:23 PM, Ben Pfaff wrote: > On Mon, Aug 04, 2014 at 05:40:24PM -0700, Justin Pettit wrote: >> On

Re: [ovs-dev] [PATCH] ofproto-dpif: Use DPIF_FP_CREATE but not DPIF_FP_MODIFY.

2014-08-04 Thread Ben Pfaff
On Mon, Aug 04, 2014 at 05:40:24PM -0700, Justin Pettit wrote: > On August 4, 2014 at 12:23:16 PM, Ben Pfaff (b...@nicira.com) wrote: > > > > I applied your ack and pushed this to master. > > Ben, we've seen this issue in pre-release versions of 2.3. ??Would you > mind backporting it to branch-2

Re: [ovs-dev] [PATCH] ofproto-dpif: Use DPIF_FP_CREATE but not DPIF_FP_MODIFY.

2014-08-04 Thread Justin Pettit
On August 4, 2014 at 12:23:16 PM, Ben Pfaff (b...@nicira.com) wrote: > > I applied your ack and pushed this to master. Ben, we've seen this issue in pre-release versions of 2.3.  Would you mind backporting it to branch-2.3, also? Thanks, --Justin ___

Re: [ovs-dev] [PATCH] ofproto-dpif: Use DPIF_FP_CREATE but not DPIF_FP_MODIFY.

2014-08-04 Thread Ben Pfaff
On Mon, Aug 04, 2014 at 11:32:17AM -0700, Jesse Gross wrote: > On Mon, Aug 4, 2014 at 10:50 AM, Ben Pfaff wrote: > > On Mon, Aug 04, 2014 at 10:15:17AM -0700, Jesse Gross wrote: > >> On Fri, Aug 1, 2014 at 5:22 PM, Ben Pfaff wrote: > >> > A dpif reports EEXIST if a flow put operation that should

Re: [ovs-dev] [PATCH] ofproto-dpif: Use DPIF_FP_CREATE but not DPIF_FP_MODIFY.

2014-08-04 Thread Jesse Gross
On Mon, Aug 4, 2014 at 10:50 AM, Ben Pfaff wrote: > On Mon, Aug 04, 2014 at 10:15:17AM -0700, Jesse Gross wrote: >> On Fri, Aug 1, 2014 at 5:22 PM, Ben Pfaff wrote: >> > A dpif reports EEXIST if a flow put operation that should create a new flow >> > instead attempts to modify an existing flow, o

Re: [ovs-dev] [PATCH] ofproto-dpif: Use DPIF_FP_CREATE but not DPIF_FP_MODIFY.

2014-08-04 Thread Ben Pfaff
On Mon, Aug 04, 2014 at 10:15:17AM -0700, Jesse Gross wrote: > On Fri, Aug 1, 2014 at 5:22 PM, Ben Pfaff wrote: > > A dpif reports EEXIST if a flow put operation that should create a new flow > > instead attempts to modify an existing flow, or ENOENT if a flow put would > > create a flow that over

Re: [ovs-dev] [PATCH] ofproto-dpif: Use DPIF_FP_CREATE but not DPIF_FP_MODIFY.

2014-08-04 Thread Jesse Gross
On Fri, Aug 1, 2014 at 5:22 PM, Ben Pfaff wrote: > A dpif reports EEXIST if a flow put operation that should create a new flow > instead attempts to modify an existing flow, or ENOENT if a flow put would > create a flow that overlaps some existing flow. The latter does not always > indicate a bug