Thanks,
Pushed to master.
On Wed, Nov 30, 2011 at 2:03 PM, Ben Pfaff wrote:
> Thanks, that's just what I had in mind.
>
> On Wed, Nov 30, 2011 at 02:06:05PM -0800, Pravin B Shelar wrote:
>> Following is incremental patch according to comments from Ben.
>>
>> --8<--cut her
Thanks, that's just what I had in mind.
On Wed, Nov 30, 2011 at 02:06:05PM -0800, Pravin B Shelar wrote:
> Following is incremental patch according to comments from Ben.
>
> --8<--cut here-->8--
>
> ---
> ofproto/ofproto-dpif.c | 16 +---
This not only improves logging, it's also a nice cleanup. Thank you, I
didn't expect that part.
I see one nit: in the update_stats() case where we log, please use
VLOG_DROP_WARN() followed by plain VLOG_WARN() to avoid formatting the
log message in the case where it is just going to get discarded
