Re: [ovs-dev] [PATCH] ofproto: flush groups and meters in ofproto_flush__

2014-10-02 Thread Joe Stringer
Hmm. This time the patch is littered with extra spaces all through the email. If you're able to use them, "git format-patch" and "git send-email" is a good way to send your patches out reliably without mail clients interfering with the presentation of the patch. I took a look at the group deletio

Re: [ovs-dev] [PATCH] ofproto: flush groups and meters in ofproto_flush__

2014-10-01 Thread Gur Stavi
ovs-dev] [PATCH] ofproto: flush groups and meters in ofproto_flush__ Hi Gur, looks straightforward. I have a few broad feedback points though: If you haven't read it yet, please take a look at the CONTRIBUTING file in the top of the source tree. I'm not sure what format this patch is in, b

Re: [ovs-dev] [PATCH] ofproto: flush groups and meters in ofproto_flush__

2014-10-01 Thread Joe Stringer
Hi Gur, looks straightforward. I have a few broad feedback points though: If you haven't read it yet, please take a look at the CONTRIBUTING file in the top of the source tree. I'm not sure what format this patch is in, but git won't accept it in my setup. I suspect it's due to the footer message