Re: [ovs-dev] [PATCH] ofproto: Fix potential leak during flow mods.

2014-04-30 Thread Jarno Rajahalme
On Apr 30, 2014, at 3:07 PM, Ethan Jackson wrote: > I'm not sure of a good way to make them fit . . . > Oops, it was my email client with variable width font that created an “optical illusion of space”… Jarno > At any rate, I'm getting rid of the rule_from_cls_rule() function in a > futur

Re: [ovs-dev] [PATCH] ofproto: Fix potential leak during flow mods.

2014-04-30 Thread Ethan Jackson
I'm not sure of a good way to make them fit . . . At any rate, I'm getting rid of the rule_from_cls_rule() function in a future patch so that will clean this up quite a bit. Ethan On Wed, Apr 30, 2014 at 3:02 PM, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > I would put the match and

Re: [ovs-dev] [PATCH] ofproto: Fix potential leak during flow mods.

2014-04-30 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme I would put the match and priority parameters on the same line, though. Jarno On Apr 30, 2014, at 2:53 PM, Ethan Jackson wrote: > This code created a cls_rule without destroying it. Found by > inspection. > > Signed-off-by: Ethan Jackson > --- > ofproto/ofproto.