Re: [ovs-dev] [PATCH] ofproto: Fix MPLS multiple Push pop action.

2015-02-26 Thread Pravin Shelar
On Sat, Feb 14, 2015 at 10:33 AM, Simon Horman wrote: > On Thu, Dec 18, 2014 at 10:31:43AM -0800, Pravin Shelar wrote: >> On Tue, Dec 16, 2014 at 3:10 PM, Jarno Rajahalme >> wrote: >> > LGTM, >> > >> > With some comments below: >> > >> > Acked-by: Jarno Rajahalme >> > >> > Jarno >> > >> > On

Re: [ovs-dev] [PATCH] ofproto: Fix MPLS multiple Push pop action.

2015-02-14 Thread Simon Horman
On Thu, Dec 18, 2014 at 10:31:43AM -0800, Pravin Shelar wrote: > On Tue, Dec 16, 2014 at 3:10 PM, Jarno Rajahalme > wrote: > > LGTM, > > > > With some comments below: > > > > Acked-by: Jarno Rajahalme > > > > Jarno > > > > On Dec 15, 2014, at 12:37 PM, Pravin B Shelar wrote: > > > >> vSwitchd

Re: [ovs-dev] [PATCH] ofproto: Fix MPLS multiple Push pop action.

2014-12-19 Thread Pravin Shelar
On Fri, Dec 19, 2014 at 11:17 AM, Joe Stringer wrote: > On 15 December 2014 at 12:37, Pravin B Shelar wrote: >> vSwitchd does not generate correct MPLS actions for multiple >> MPLS push or pop action. >> Datapath can handle multiple push action for in single action list. >> But for after first MP

Re: [ovs-dev] [PATCH] ofproto: Fix MPLS multiple Push pop action.

2014-12-19 Thread Joe Stringer
On 15 December 2014 at 12:37, Pravin B Shelar wrote: > vSwitchd does not generate correct MPLS actions for multiple > MPLS push or pop action. > Datapath can handle multiple push action for in single action list. > But for after first MPLS pop it needs to recirculate packet to > refill packet key.

Re: [ovs-dev] [PATCH] ofproto: Fix MPLS multiple Push pop action.

2014-12-18 Thread Pravin Shelar
On Tue, Dec 16, 2014 at 3:10 PM, Jarno Rajahalme wrote: > LGTM, > > With some comments below: > > Acked-by: Jarno Rajahalme > > Jarno > > On Dec 15, 2014, at 12:37 PM, Pravin B Shelar wrote: > >> vSwitchd does not generate correct MPLS actions for multiple >> MPLS push or pop action. >> Datapa

Re: [ovs-dev] [PATCH] ofproto: Fix MPLS multiple Push pop action.

2014-12-16 Thread Jarno Rajahalme
LGTM, With some comments below: Acked-by: Jarno Rajahalme Jarno On Dec 15, 2014, at 12:37 PM, Pravin B Shelar wrote: > vSwitchd does not generate correct MPLS actions for multiple > MPLS push or pop action. > Datapath can handle multiple push action for in single action list. > But for aft