Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-09-02 Thread Daniele Di Proietto
On 01/09/2016 12:59, "Thadeu Lima de Souza Cascardo" wrote: >On Thu, Sep 01, 2016 at 05:17:44PM +, Daniele Di Proietto wrote: >> Let me try to sum up the problem further >> >> 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU >> for new internal ports."): >>

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-09-02 Thread Daniele Di Proietto
On 01/09/2016 11:07, "Jesse Gross" wrote: >On Thu, Sep 1, 2016 at 10:17 AM, Daniele Di Proietto > wrote: >> Let me try to sum up the problem further >> >> 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU >> for new internal ports."): >> >> a) When an internal i

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-09-01 Thread Thadeu Lima de Souza Cascardo
On Thu, Sep 01, 2016 at 05:17:44PM +, Daniele Di Proietto wrote: > Let me try to sum up the problem further > > 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU > for new internal ports."): > > a) When an internal interface is added, or its MTU has changed we on

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-09-01 Thread Jesse Gross
On Thu, Sep 1, 2016 at 10:17 AM, Daniele Di Proietto wrote: > Let me try to sum up the problem further > > 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU > for new internal ports."): > > a) When an internal interface is added, or its MTU has changed we only > chan

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-09-01 Thread Daniele Di Proietto
Let me try to sum up the problem further 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU for new internal ports."): a) When an internal interface is added, or its MTU has changed we only change its MTU if it is bigger than the bridge minimum b) When a non inte

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-09-01 Thread Daniele Di Proietto
Hi Darrel, thanks for your comments Replies inline On 31/08/2016 21:02, "Darrell Ball" wrote: > > >On Wed, Aug 31, 2016 at 6:48 PM, Joe Stringer > wrote: > >On 31 August 2016 at 14:52, Daniele Di Proietto wrote: >> Open vSwitch controls the MTU of internal ports and sets it to the >> min

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-09-01 Thread Daniele Di Proietto
Hi Joe, Thanks for your comments replies inline On 31/08/2016 18:48, "Joe Stringer" wrote: >On 31 August 2016 at 14:52, Daniele Di Proietto wrote: >> Open vSwitch controls the MTU of internal ports and sets it to the >> minimum of physical ports MTU on the same bridge. >> >> Commit 47bf118

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-08-31 Thread Darrell Ball
On Wed, Aug 31, 2016 at 6:48 PM, Joe Stringer wrote: > On 31 August 2016 at 14:52, Daniele Di Proietto > wrote: > > Open vSwitch controls the MTU of internal ports and sets it to the > > minimum of physical ports MTU on the same bridge. > > > > Commit 47bf118665a3("ofproto: Always set MTU for ne

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-08-31 Thread Joe Stringer
On 31 August 2016 at 14:52, Daniele Di Proietto wrote: > Open vSwitch controls the MTU of internal ports and sets it to the > minimum of physical ports MTU on the same bridge. > > Commit 47bf118665a3("ofproto: Always set MTU for new internal ports.") > made this more consistent. Now the MTU is al

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-08-31 Thread Darrell Ball
On Wed, Aug 31, 2016 at 2:52 PM, Daniele Di Proietto wrote: > Open vSwitch controls the MTU of internal ports and sets it to the > minimum of physical ports MTU on the same bridge. > > Commit 47bf118665a3("ofproto: Always set MTU for new internal ports.") > made this more consistent. Now the MTU