Re: [ovs-dev] [PATCH] ofproto: Allow in-place modifications of datapath flows.

2015-08-10 Thread Ethan Jackson
Your call either way. I don't feel strongly. Ethan On Thu, Aug 6, 2015 at 1:07 PM, Justin Pettit wrote: > This is cleaner than I was expecting. Do you think we want to backport it to > 2.3? > > --Justin > > >> On Aug 6, 2015, at 12:30 PM, Jarno Rajahalme wrote: >> >> Ethan, >> >> This ended

Re: [ovs-dev] [PATCH] ofproto: Allow in-place modifications of datapath flows.

2015-08-06 Thread Justin Pettit
This is cleaner than I was expecting. Do you think we want to backport it to 2.3? --Justin > On Aug 6, 2015, at 12:30 PM, Jarno Rajahalme wrote: > > Ethan, > > This ended up being a very clean patch, thank you! > > IMO this is good to go, but I’d like to see a test case that shows the modi

Re: [ovs-dev] [PATCH] ofproto: Allow in-place modifications of datapath flows.

2015-08-06 Thread Jarno Rajahalme
Ethan, This ended up being a very clean patch, thank you! IMO this is good to go, but I’d like to see a test case that shows the modify operation in the logs to prevent regression in the future. Maybe work off some of the bond rebalance test cases to prove that modify is used in the case we cu