Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-10-14 Thread Stokes, Ian
> -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Tuesday, October 13, 2015 5:14 PM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality. > > > > On

Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-10-14 Thread Stokes, Ian
> -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Tuesday, October 13, 2015 5:24 PM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality. > > On Wed, Sep 30, 2015 at 01:45:15PM

Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-10-13 Thread Ben Pfaff
On Wed, Sep 30, 2015 at 01:45:15PM +0100, Ian Stokes wrote: > This patch provides the modifications required in netdev-dpdk.c and > vswitch.xml to allow for a DPDK user space QoS algorithm. > > This patch adds a QoS configuration structure for netdev-dpdk and > expected QoS operations 'dpdk_qos_op

Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-10-13 Thread Daniele Di Proietto
gt; To: Stokes, Ian >> Cc: dev@openvswitch.org >> Subject: Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality. >> >> Hi, >> >> Thanks for the patch, the implementation looks simpler than I expected. >> >> General questions: >> >> * It

Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-10-12 Thread Stokes, Ian
Hi Daniele, Thanks for providing feedback, answers inline. > -Original Message- > From: Daniele Di Proietto [mailto:diproiet...@vmware.com] > Sent: Friday, October 09, 2015 6:53 PM > To: Stokes, Ian > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netd

Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-10-09 Thread Daniele Di Proietto
Hi, Thanks for the patch, the implementation looks simpler than I expected. General questions: * It appears that we're using the srCTM, but * We're only sending the green packets and dropping the rest. * The `input_color` is always green. Therefore * `other-config:ebs` is ignored (isn't

Re: [ovs-dev] [PATCH] netdev_dpdk.c: Add QoS functionality.

2015-10-08 Thread Stokes, Ian
Hi All, Just wondering if anyone has had time to review this? Any feedback would be much appreciated. Thanks Ian > -Original Message- > From: Stokes, Ian > Sent: Wednesday, September 30, 2015 1:45 PM > To: dev@openvswitch.org > Cc: Stokes, Ian > Subject: [PATCH] netdev_dpdk.c: Add QoS fu