Re: [ovs-dev] [PATCH] net: preserve IP control block during GSO segmentation

2016-01-11 Thread Cong Wang
On Sun, Jan 10, 2016 at 11:45 PM, Zang MingJie wrote: > On 01/08/2016 08:13 PM, David Laight wrote: >> >> You could set SKB_SGO_CB_OFFSET to sizeof ((skb)->cb) - sizeof (struct >> skb_gso_cb) >> so that the end of 'cb' is always used. >> (Assuming the former is a multiple of 4.) >> >> It might be

Re: [ovs-dev] [PATCH] net: preserve IP control block during GSO segmentation

2016-01-10 Thread Zang MingJie
On 01/08/2016 08:13 PM, David Laight wrote: You could set SKB_SGO_CB_OFFSET to sizeof ((skb)->cb) - sizeof (struct skb_gso_cb) so that the end of 'cb' is always used. (Assuming the former is a multiple of 4.) It might be worth using an on-stack structure passed through as a separate paramete

Re: [ovs-dev] [PATCH] net: preserve IP control block during GSO segmentation

2016-01-08 Thread kbuild test robot
Hi Konstantin, [auto build test ERROR on net/master] [also build test ERROR on v4.4-rc8 next-20160108] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Konstantin-Khlebnikov/net-preserve-IP-cont

Re: [ovs-dev] [PATCH] net: preserve IP control block during GSO segmentation

2016-01-08 Thread Thadeu Lima de Souza Cascardo
On Fri, Jan 08, 2016 at 12:13:49PM +, David Laight wrote: > From: Of Konstantin Khlebnikov > > Sent: 08 January 2016 12:01 > > Skb_gso_segment() uses skb control block during segmentation. > > This patch adds 32-bytes room for previous control block which > > will be copied into all resulting s

Re: [ovs-dev] [PATCH] net: preserve IP control block during GSO segmentation

2016-01-08 Thread David Laight
From: Of Konstantin Khlebnikov > Sent: 08 January 2016 12:01 > Skb_gso_segment() uses skb control block during segmentation. > This patch adds 32-bytes room for previous control block which > will be copied into all resulting segments. > > This patch fixes kernel crash during fragmenting forwarded

Re: [ovs-dev] [PATCH] net: preserve IP control block during GSO segmentation

2016-01-08 Thread Thadeu Lima de Souza Cascardo
On Fri, Jan 08, 2016 at 03:00:41PM +0300, Konstantin Khlebnikov wrote: > Skb_gso_segment() uses skb control block during segmentation. > This patch adds 32-bytes room for previous control block which > will be copied into all resulting segments. > > This patch fixes kernel crash during fragmenting

Re: [ovs-dev] [PATCH] net: preserve IP control block during GSO segmentation

2016-01-08 Thread Konstantin Khlebnikov
On Fri, Jan 8, 2016 at 3:00 PM, Konstantin Khlebnikov wrote: > Skb_gso_segment() uses skb control block during segmentation. > This patch adds 32-bytes room for previous control block which > will be copied into all resulting segments. > > This patch fixes kernel crash during fragmenting forwarded