On Wed, Aug 27, 2014 at 08:54:47AM -0700, Gurucharan Shetty wrote:
> On Tue, Aug 26, 2014 at 4:08 PM, Ben Pfaff wrote:
> > On Tue, Aug 26, 2014 at 04:04:09PM -0700, Jarno Rajahalme wrote:
> >>
> >> On Aug 26, 2014, at 3:53 PM, Ben Pfaff wrote:
> >>
> >> > On Tue, Aug 26, 2014 at 03:42:33PM -0700,
On Tue, Aug 26, 2014 at 4:08 PM, Ben Pfaff wrote:
> On Tue, Aug 26, 2014 at 04:04:09PM -0700, Jarno Rajahalme wrote:
>>
>> On Aug 26, 2014, at 3:53 PM, Ben Pfaff wrote:
>>
>> > On Tue, Aug 26, 2014 at 03:42:33PM -0700, Jarno Rajahalme wrote:
>> >> Finally, use change the storage type of 'values_i
On Aug 26, 2014, at 5:13 PM, Ben Pfaff wrote:
> On Wed, Aug 27, 2014 at 12:11:34AM +, Saurabh Shah wrote:
>>
>> I reverted uint8_t -> uint64_t and was able to move past compile flow.h.
>
> OK, so much for that idea. Jarno, let's stick with uint64_t then?
Reverted back to uint64_t on mast
On Wed, Aug 27, 2014 at 12:11:34AM +, Saurabh Shah wrote:
> > -Original Message-
> > From: Ben Pfaff [mailto:b...@nicira.com]
> > Sent: Tuesday, August 26, 2014 4:56 PM
> > To: Saurabh Shah
> > Cc: Jarno Rajahalme; dev@openvswitch.org
> > Subje
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Tuesday, August 26, 2014 4:56 PM
> To: Saurabh Shah
> Cc: Jarno Rajahalme; dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] lib/flow.h: Improve struct miniflow comment
> and definition.
>
&
On Tue, Aug 26, 2014 at 11:32:55PM +, Saurabh Shah wrote:
>
>
> >Miniflows can nowadays be dynamically allocated to different inline
> >sizes, as done by lib/classifier.c, but this had not been documented
> >at the struct miniflow definition.
> >
> >Also, MINI_N_INLINE had a different value f
>Miniflows can nowadays be dynamically allocated to different inline
>sizes, as done by lib/classifier.c, but this had not been documented
>at the struct miniflow definition.
>
>Also, MINI_N_INLINE had a different value for 32-bit and 64-bit builds
>due to a historical reason. Now we use 8 for b
On Tue, Aug 26, 2014 at 04:05:31PM -0700, Jarno Rajahalme wrote:
> I forgot to add your Reviewed-by:, and it seems it is not possible
> to ?git commit ?amend? a commit that already is at github ? or is
> it?
You can do it with a forced push, e.g. "git push --force". It is
risky, though, so one sh
On Tue, Aug 26, 2014 at 04:04:09PM -0700, Jarno Rajahalme wrote:
>
> On Aug 26, 2014, at 3:53 PM, Ben Pfaff wrote:
>
> > On Tue, Aug 26, 2014 at 03:42:33PM -0700, Jarno Rajahalme wrote:
> >> Finally, use change the storage type of 'values_inline' to uint8_t, as
> >> uint64_t looks kind of wide f
On Aug 26, 2014, at 3:44 PM, Thomas Graf wrote:
> On 08/26/14 at 03:42pm, Jarno Rajahalme wrote:
>> Miniflows can nowadays be dynamically allocated to different inline
>> sizes, as done by lib/classifier.c, but this had not been documented
>> at the struct miniflow definition.
>>
>> Also, MINI_
On Aug 26, 2014, at 3:53 PM, Ben Pfaff wrote:
> On Tue, Aug 26, 2014 at 03:42:33PM -0700, Jarno Rajahalme wrote:
>> Finally, use change the storage type of 'values_inline' to uint8_t, as
>> uint64_t looks kind of wide for a boolean, even though we intend the
>> bit be carved out from the uint64_
On Tue, Aug 26, 2014 at 03:42:33PM -0700, Jarno Rajahalme wrote:
> Finally, use change the storage type of 'values_inline' to uint8_t, as
> uint64_t looks kind of wide for a boolean, even though we intend the
> bit be carved out from the uint64_t where 'map' resides.
It can't be type "bool"?
_
On 08/26/14 at 03:42pm, Jarno Rajahalme wrote:
> Miniflows can nowadays be dynamically allocated to different inline
> sizes, as done by lib/classifier.c, but this had not been documented
> at the struct miniflow definition.
>
> Also, MINI_N_INLINE had a different value for 32-bit and 64-bit build
13 matches
Mail list logo
