Re: [ovs-dev] [PATCH] hmap: Make bad hash functions easier to find.

2013-09-24 Thread Ben Pfaff
Thanks Keith and Justin, I applied this to master and branch-2.0. On Tue, Sep 24, 2013 at 02:33:53PM -0700, Justin Pettit wrote: > Acked-by: Justin Pettit > > > On Sep 24, 2013, at 10:17 AM, Ben Pfaff wrote: > > > The hmap code has for a long time incremented a counter when a hash bucket > >

Re: [ovs-dev] [PATCH] hmap: Make bad hash functions easier to find.

2013-09-24 Thread Justin Pettit
Acked-by: Justin Pettit On Sep 24, 2013, at 10:17 AM, Ben Pfaff wrote: > The hmap code has for a long time incremented a counter when a hash bucket > grew to have many entries. This can let a developer know that some hash > function is performing poorly, but doesn't give any hint as to which

Re: [ovs-dev] [PATCH] hmap: Make bad hash functions easier to find.

2013-09-24 Thread Keith Amidon
Nice! Looks very useful and a nice contained implementation. :-) --- Keith {-- Tue, 24 Sep 2013 10:17:45 -0700: Ben wrote: --} Ben> The hmap code has for a long time incremented a counter when a hash bucket Ben> grew to have many entries. This can let a developer know that some hash