Re: [ovs-dev] [PATCH] datapath-windows Event read handler

2014-09-25 Thread Samuel Ghinet
Hey Eitan, > */ > #if defined OVS_USE_NL_INTERFACE && OVS_USE_NL_INTERFACE == 1 > > +#pragma warning( push ) > +#pragma warning( disable:4127 ) > + > #include "precomp.h" Could you put some doc comment saying what warning you are disabling, and perhaps, why? :) You've got a few "else"-s lik

Re: [ovs-dev] [PATCH] datapath-windows Event read handler

2014-09-24 Thread Eitan Eliahu
Thanks Alin for the review. I'll fix and send a new patch. Eitan -Original Message- From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com] Sent: Wednesday, September 24, 2014 4:56 PM To: Eitan Eliahu; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows Event

Re: [ovs-dev] [PATCH] datapath-windows Event read handler

2014-09-24 Thread Alin Serdean
Hi Eitan, 1. Git apply whitespaces $ git apply ovs-dev-datapath-windows-Event-read-handler.patch ovs-dev-datapath-windows-Event-read-handler.patch:108: trailing whitespace. * Utility function to fill up information about the state of a port in a reply ovs-dev-datapath-windows-Event-read-handler.p