Re: [ovs-dev] [PATCH] datapath-windows: check source port during tunnel Tx

2014-08-14 Thread Nithin Raju
> I saw that Ben already applied this patch yesterday. However, I just have one > comment below. Np. I'll take care of review comments in a followup patch. >> +/* >> + * Tx: >> + * The destination port is a tunnel port. Encapsulation must be >> + * performed only

Re: [ovs-dev] [PATCH] datapath-windows: check source port during tunnel Tx

2014-08-14 Thread Saurabh Shah
Hi Nithin, I saw that Ben already applied this patch yesterday. However, I just have one comment below. > -Original Message- > From: Nithin Raju [mailto:nit...@vmware.com] > Sent: Tuesday, August 12, 2014 10:59 PM > To: dev@openvswitch.org; Saurabh Shah > Cc: Nithin Raju > Subject: [PATC

Re: [ovs-dev] [PATCH] datapath-windows: check source port during tunnel Tx

2014-08-13 Thread Ben Pfaff
On Tue, Aug 12, 2014 at 10:59:29PM -0700, Nithin Raju wrote: > In the Windows datapath, Tx tunneling functionality is implemented by checking > if the outport in the action is a tunnel port. If so, the packet is > encapsulated and sent out on the PIF bridge for as second flow lookup. > Basically, w

Re: [ovs-dev] [PATCH] datapath-windows: check source port during tunnel Tx

2014-08-13 Thread Nithin Raju
On Aug 13, 2014, at 1:07 PM, Alin Serdean wrote: > Very sporadic times. > > Will continue my testing and review tomorrow. > > Just wanted to let you know :). Thanks Alin for the review and validation. I also left a VIF <-> VIF VXLAN based ping overnight. Still going strong. -- Nithin

Re: [ovs-dev] [PATCH] datapath-windows: check source port during tunnel Tx

2014-08-13 Thread Alin Serdean
Hi Nithin, At first glance everything seems good. I even tested it out between a HyperV and KVM hypervisor setup. On HyperV: PS C:\package\binaries> .\ovsset.ps1 system@ovs-system: lookups: hit:34 missed:273 lost:0 flows: 0 masks: hit:0 total:0 hit/pkt:0.00 port 1

Re: [ovs-dev] [PATCH] datapath-windows: check source port during tunnel Tx

2014-08-13 Thread Nithin Raju
On Aug 13, 2014, at 8:24 AM, Alin Serdean wrote: > I will take a look over the patch after the meeting. Sounds good. thanks, Nithin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath-windows: check source port during tunnel Tx

2014-08-13 Thread Alin Serdean
Hey Nithin, I will take a look over the patch after the meeting. Thanks, Alin. -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju Trimis: Wednesday, August 13, 2014 8:59 AM Către: dev@openvswitch.org; ssaur...@vmware.com Subiect: [ovs-dev] [PATCH] data