Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-24 Thread Sorin Vinturis
nvswitch.org > > Subject: RE: [ovs-dev] [PATCH] datapath-windows: Updated WFP system > > provider handling > > > > Thanks Sorin, > > What would be the case where BFE is not started before the driver > > initializes? > > When BFE is not started does the driver continue with WFP rule

Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-24 Thread Ben Pfaff
tan > > -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Tuesday, March 24, 2015 10:01 AM > To: Eitan Eliahu > Cc: Sorin Vinturis; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider > handling >

Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-24 Thread Eitan Eliahu
> Thanks Sorin. > Eitan > > -Original Message- > From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com] > Sent: Tuesday, March 24, 2015 12:29 AM > To: Eitan Eliahu > Cc: dev@openvswitch.org > Subject: RE: [ovs-dev] [PATCH] datapath-windows: Updated WFP system &

Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-24 Thread Ben Pfaff
Sorin. > Eitan > > -Original Message- > From: Sorin Vinturis [mailto:svintu...@cloudbasesolutions.com] > Sent: Tuesday, March 24, 2015 12:29 AM > To: Eitan Eliahu > Cc: dev@openvswitch.org > Subject: RE: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider >

Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-24 Thread Eitan Eliahu
rformed at boot time. Thanks, Sorin -Original Message- From: Eitan Eliahu [mailto:elia...@vmware.com] Sent: Tuesday, 24 March, 2015 06:37 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling Thanks Sorin, Wh

Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-24 Thread Sorin Vinturis
rformed at boot time. Thanks, Sorin -Original Message- From: Eitan Eliahu [mailto:elia...@vmware.com] Sent: Tuesday, 24 March, 2015 06:37 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling Thanks Sorin, What would b

Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-23 Thread Eitan Eliahu
:40 PM To: Sorin Vinturis; Eitan Eliahu Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling As I explained in the patch description, I have added this change because, at driver initialization phase, the system provider failed to be added due

Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-23 Thread Sorin Vinturis
. -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis Sent: Tuesday, 24 March, 2015 01:01 To: Eitan Eliahu Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling Hi Eitan, In this case the

Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-23 Thread Sorin Vinturis
iginal Message- From: Eitan Eliahu [mailto:elia...@vmware.com] Sent: Monday, 23 March, 2015 18:13 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling Sorin, Ok on [1]. Thanks. On [2], I can see a scenario when the

Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-23 Thread Eitan Eliahu
Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling Hi Eitan, Thanks for reviewing my patch. [1] The OvsTunnelEngineClose(HANDLE *handle) is verifying the handle it receives before closing it. [2] In order to retrieve the current state

Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-23 Thread Sorin Vinturis
:32 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling Hi Sorin, Thank you for posting this change. Here are few comments: [1] Please call OvsTunnelEngineClose(&handle) only if the handle is not zero. (you might wan

Re: [ovs-dev] [PATCH] datapath-windows: Updated WFP system provider handling

2015-03-22 Thread Eitan Eliahu
Hi Sorin, Thank you for posting this change. Here are few comments: [1] Please call OvsTunnelEngineClose(&handle) only if the handle is not zero. (you might want to add an assertion if it zero). [2] I'm somewhat confused about the registration for engine state change. As I understand you check t