Re: [ovs-dev] [PATCH] datapath-windows: Surpress flow attribute probe

2015-08-28 Thread Ben Pfaff
On Thu, Aug 27, 2015 at 07:57:14PM +, Nithin Raju wrote: > > This patch surpresses flow attribute probing in the windows datapath. > > > > Signed-off-by: Alin Gabriel Serdean > > The change look good. Only thing I’d avoid is the OVS_LOG_ERROR() > statement. The documentation for ‘OVS_FLOW_AT

Re: [ovs-dev] [PATCH] datapath-windows: Surpress flow attribute probe

2015-08-27 Thread Nithin Raju
> This patch surpresses flow attribute probing in the windows datapath. > > Signed-off-by: Alin Gabriel Serdean Alin, The change look good. Only thing I’d avoid is the OVS_LOG_ERROR() statement. The documentation for ‘OVS_FLOW_ATTR_PROBE’ explicitly mentions that logging should be suppressed.