Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-04 Thread Sorin Vinturis
ndisHandle check instead of the code you are referring. The v2 patch got committed. -Sorin -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Tuesday, 4 August, 2015 16:36 To: Sorin Vinturis Cc: Eitan Eliahu; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-04 Thread Nithin Raju
> On Aug 4, 2015, at 1:45 AM, Sorin Vinturis > wrote: > > Nithin, that check (if (nbl->SourceHandle == context->ovsPool.ndisHandle) ..) > at L564 was added by my patch. Please see here: > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs_commit_d50b88bf830c401636

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-04 Thread Sorin Vinturis
re.com] Sent: Monday, 3 August, 2015 15:45 To: Sorin Vinturis Cc: Eitan Eliahu; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports > On Aug 2, 2015, at 9:33 PM, Sorin Vinturis > wrote: > > Hi Nithin, > > Yes, the second chec

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-03 Thread Nithin Raju
> On Aug 2, 2015, at 9:33 PM, Sorin Vinturis > wrote: > > Hi Nithin, > > Yes, the second check, from the 564 line, is caught by the case when the > OvsInitExternalNBLContext() function is called with the NBL created by > OvsPartialCopyNBL(). Right, so, do we still need your patch since L564

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-02 Thread Sorin Vinturis
To: Eitan Eliahu Cc: Sorin Vinturis; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports hi Sorin, In OvsInitExternalNBLContext(), there’s the following check: 563 if (poolHandle == context->ovsPool.ndisHandle ||

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-31 Thread Nithin Raju
hi Sorin, In OvsInitExternalNBLContext(), there’s the following check: 563 if (poolHandle == context->ovsPool.ndisHandle || 564 nbl->SourceHandle == context->ovsPool.ndisHandle) { 565 return (POVS_BUFFER_CONTEXT)NET_BUFFER_LIST_CONTEXT_

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-30 Thread Sorin Vinturis
Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports hi Sorin, OvsInitExternalNBLContext() is called from OvsStartNBLIngress() which is the function that hooks into NDIS to get hold of packets in the ingress path. Typically these are

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-30 Thread Nithin Raju
hi Sorin, OvsInitExternalNBLContext() is called from OvsStartNBLIngress() which is the function that hooks into NDIS to get hold of packets in the ingress path. Typically these are packets that are generated by VMs, or it could be generated by an layered driver above OVS. Under what conditions

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-01 Thread Eitan Eliahu
-Original Message- From: Eitan Eliahu [mailto:elia...@vmware.com] Sent: Wednesday, 1 July, 2015 18:12 To: Sorin Vinturis; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports Hi Sorin, Thank you for debugging this issue. I think that the NBL

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-01 Thread Sorin Vinturis
: Eitan Eliahu [mailto:elia...@vmware.com] Sent: Wednesday, 1 July, 2015 18:12 To: Sorin Vinturis; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports Hi Sorin, Thank you for debugging this issue. I think that the NBL context signature is used for

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-07-01 Thread Eitan Eliahu
Hi Sorin, Thank you for debugging this issue. I think that the NBL context signature is used for code validation only (think about a signature we put in an object for the purpose of validating this object when executing in a different context). Can you think about another way to fix this issue (e