Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-26 Thread Ben Pfaff
t; Trimis: Wednesday, November 26, 2014 12:10 AM > Către: Alin Serdean > Cc: dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling > driver > > On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote: > > Add an additional ch

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-26 Thread Alin Serdean
12:10 AM Către: Alin Serdean Cc: dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote: > Add an additional check to see if the flowTable is not NULL. Hi Alin, can you provide a Sig

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Ben Pfaff
OK, thanks for letting me know, I had the impression it was ready. On Tue, Nov 25, 2014 at 10:15:19PM +, Nithin Raju wrote: > Hi Ben, > This change is not good to go. Alin has filed a bug for investigating this. > Sorin or I will address it soon. > > Thanks, > -- Nithin > > - sent from mobi

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Nithin Raju
Hi Ben, This change is not good to go. Alin has filed a bug for investigating this. Sorin or I will address it soon. Thanks, -- Nithin - sent from mobile - > On Nov 25, 2014, at 14:11, "Ben Pfaff" wrote: > >> On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote: >> Add an additional c

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Ben Pfaff
On Tue, Nov 25, 2014 at 05:09:29PM +, Alin Serdean wrote: > Add an additional check to see if the flowTable is not NULL. Hi Alin, can you provide a Signed-off-by? Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Nithin Raju
On Nov 25, 2014, at 9:09 AM, Alin Serdean wrote: > +if (datapath->flowTable == NULL) { > +status = STATUS_INVALID_PARAMETER; > +goto dp_unlock; > +} Alin, We allocate the flow table in OvsAllocateFlowTable() when the datapath is allocated, which is when the 'gOvsSwitchC

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Eitan Eliahu
Hi Alin, Thank you for fixing this issue. Do you think we can acquire the lock in OvsDeleteFlowTable() ? Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Tuesday, November 25, 2014 9:09 AM To: dev@openvswitch.org Subject: [ovs-dev] [

Re: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver

2014-11-25 Thread Sorin Vinturis
Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Tuesday, 25 November, 2014 19:09 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Fix BSOD when uninstalling driver Add an additional check to se