Re: [ovs-dev] [PATCH] datapath-windows: Add Core.h

2014-08-06 Thread Samuel Ghinet
Hello Eitan, Two pair of eyes are better than one! Anyway, reading a bit further of what you read: "The "only NDIS APIs" rule is meant to cover areas that are more central to networking, like DMA, interrupts, DPCs, and IRPs. For that sort of thing, miniport drivers must either go through NDIS,

Re: [ovs-dev] [PATCH] datapath-windows: Add Core.h

2014-08-06 Thread Eitan Eliahu
Sam, I think Microsoft official recommendation is to NDIS wrapper calls (for certification). I came across the following when I read same the thread you pointed out: "I remember an invigorated discussion here some time ago regarding the necessity to use NDIS APIs inside NDIS drivers in order t

Re: [ovs-dev] [PATCH] datapath-windows: Add Core.h

2014-08-06 Thread Samuel Ghinet
Hello Eitan, Just found this (it is an answer on a thread, not true doc, but may be helpful): "I would actually suggest avoiding the NdisAllocateMemory* APIs for general pool allocations, and going straight to the ExAllocate APIs. There's nothing interesting going on in the NDIS APIs, and the k

Re: [ovs-dev] [PATCH] datapath-windows: Add Core.h

2014-08-06 Thread Eitan Eliahu
Hi Sam, Since the switch extension driver is an NDIS filter driver it would be preferable to use NDIS memory allocation functions rather direct executive system calls. On another thing: since this driver is basically two combined drivers (Extension and WFP) it would be nice if we could pass