Re: [ovs-dev] [PATCH] datapath: remove RCU annotation from flow->mask

2013-07-22 Thread Andy Zhou
Done. On Mon, Jul 22, 2013 at 2:53 PM, Jesse Gross wrote: > OK, although the patch also needs a signed-off-by from you and I think > that we can also remove an ugly cast from ovs_flow_free(). Do you just > want to send out a new version? > > On Mon, Jul 22, 2013 at 2:35 PM, Andy Zhou wrote: >

Re: [ovs-dev] [PATCH] datapath: remove RCU annotation from flow->mask

2013-07-22 Thread Jesse Gross
OK, although the patch also needs a signed-off-by from you and I think that we can also remove an ugly cast from ovs_flow_free(). Do you just want to send out a new version? On Mon, Jul 22, 2013 at 2:35 PM, Andy Zhou wrote: > Sorry forgot to mention Ben reported this issue. Jesse, would you pleas

Re: [ovs-dev] [PATCH] datapath: remove RCU annotation from flow->mask

2013-07-22 Thread Andy Zhou
Sorry forgot to mention Ben reported this issue. Jesse, would you please add it before committing? On Mon, Jul 22, 2013 at 2:30 PM, Ben Pfaff wrote: > On Mon, Jul 22, 2013 at 02:28:04PM -0700, Andy Zhou wrote: > > After a mask is assigned to a flow, it will not change for the life of > > the fl

Re: [ovs-dev] [PATCH] datapath: remove RCU annotation from flow->mask

2013-07-22 Thread Ben Pfaff
On Mon, Jul 22, 2013 at 02:28:04PM -0700, Andy Zhou wrote: > After a mask is assigned to a flow, it will not change for the life of > the flow. Since flow access is protected by RCU lock, access to > flow->mask after getting a flow is always safe. > > Suggested-by: Jesse Gross This patch fixes t