Thanks for the review, I'll merge this shortly.
Ethan
On Tue, Oct 9, 2012 at 3:16 PM, Ben Pfaff wrote:
> On Tue, Oct 09, 2012 at 03:09:51PM -0700, Ethan Jackson wrote:
>> Here's an incremental.
>
> Thanks for humoring me, this seems fine.
___
dev maili
On Tue, Oct 09, 2012 at 03:09:51PM -0700, Ethan Jackson wrote:
> Here's an incremental.
Thanks for humoring me, this seems fine.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Here's an incremental.
---
configure.ac| 4 ++--
lib/socket-util.c | 12 +---
lib/timeval.c | 42 +++---
lib/timeval.h | 16
tests/test-timeval.c| 4 ++--
vswitchd/system-stats.c | 21
On Tue, Oct 09, 2012 at 02:21:08PM -0700, Ethan Jackson wrote:
> > Maybe I'm mistaken, but IIRC ESX is the only case we know of where
> > timer_create() doesn't work. We previously found this out only at
> > runtime, but with your change we will instead disable timer caching at
> > compile time so
> Maybe I'm mistaken, but IIRC ESX is the only case we know of where
> timer_create() doesn't work. We previously found this out only at
> runtime, but with your change we will instead disable timer caching at
> compile time so there's now (again) no need to disable it at runtime.
> No?
True, I a
On Tue, Oct 09, 2012 at 01:54:28PM -0700, Ethan Jackson wrote:
> > Does the 'argv' code in command-line.c actually malfunction on ESX?
> > It'd be nice to just leave it in, if not. It's not really tied to
> > having the Linux datapath, it's orthogonal. (It should actually work
> > on many Unix an
> Does the 'argv' code in command-line.c actually malfunction on ESX?
> It'd be nice to just leave it in, if not. It's not really tied to
> having the Linux datapath, it's orthogonal. (It should actually work
> on many Unix and Unix-like systems, but we specialize it to Linux
> pending testing on
On Mon, Oct 08, 2012 at 12:49:21PM -0700, Ethan Jackson wrote:
> The ESX userspace looks quite a bit like linux, but has some key
> differences which need to be specially handled in the build. To
> distinguish between ESX and systems use the linux datapath module,
> this patch adds two new macros
