Re: [ovs-dev] [PATCH] Genericize/simplify kernel sFlow implementation

2011-09-13 Thread Jesse Gross
On Tue, Sep 13, 2011 at 10:55 AM, Pravin Shelar wrote: > On Mon, Sep 12, 2011 at 4:37 PM, Jesse Gross wrote: >> On Tue, Aug 30, 2011 at 6:59 PM, Pravin Shelar wrote: >>> diff --git a/datapath/actions.c b/datapath/actions.c >>> index 8aec438..3178bdd 100644 >>> --- a/datapath/actions.c >>> +++ b/

Re: [ovs-dev] [PATCH] Genericize/simplify kernel sFlow implementation

2011-09-13 Thread Pravin Shelar
On Mon, Sep 12, 2011 at 4:37 PM, Jesse Gross wrote: > On Tue, Aug 30, 2011 at 6:59 PM, Pravin Shelar wrote: >> diff --git a/datapath/actions.c b/datapath/actions.c >> index 8aec438..3178bdd 100644 >> --- a/datapath/actions.c >> +++ b/datapath/actions.c >> +static int sample(struct datapath *dp, s

Re: [ovs-dev] [PATCH] Genericize/simplify kernel sFlow implementation

2011-09-13 Thread Jesse Gross
On Mon, Sep 12, 2011 at 4:37 PM, Jesse Gross wrote: > On Tue, Aug 30, 2011 at 6:59 PM, Pravin Shelar wrote: >>         if (ofproto->sflow) { >> +            dpif_get_dp_stats(ofproto->dpif, &s); >>             odp_flow_key_to_flow(upcall->key, upcall->key_len, &flow); >> -            dpif_sflow_r

Re: [ovs-dev] [PATCH] Genericize/simplify kernel sFlow implementation

2011-09-13 Thread Jesse Gross
One more thing: On Tue, Aug 30, 2011 at 6:59 PM, Pravin Shelar wrote: > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index f09c230..fa70be6 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -2903,6 +3023,8 @@ add_output_action(struct action_xlate_ctx *ctx

Re: [ovs-dev] [PATCH] Genericize/simplify kernel sFlow implementation

2011-09-12 Thread Jesse Gross
On Tue, Aug 30, 2011 at 6:59 PM, Pravin Shelar wrote: > diff --git a/datapath/actions.c b/datapath/actions.c > index 8aec438..3178bdd 100644 > --- a/datapath/actions.c > +++ b/datapath/actions.c > +static int sample(struct datapath *dp, struct sk_buff *skb, > +                 const struct nlattr