Re: [ovs-dev] [PATCH] Fix a bug in conversion between flow/mask and flow key

2013-08-30 Thread Guolin Yang, VMware
I will send a v2 soon based on Andy's feedback. Thanks Guolin On Thu, Aug 29, 2013 at 8:43 PM, Ben Pfaff wrote: > Andy, thanks for the review. > > Guolin, are you willing to submit a v2? > > Thanks, > > Ben. > > On Thu, Aug 29, 2013 at 05:21:03PM -0700, Andy Zhou wrote: > > Good catch. The log

Re: [ovs-dev] [PATCH] Fix a bug in conversion between flow/mask and flow key

2013-08-29 Thread Ben Pfaff
Andy, thanks for the review. Guolin, are you willing to submit a v2? Thanks, Ben. On Thu, Aug 29, 2013 at 05:21:03PM -0700, Andy Zhou wrote: > Good catch. The logic looks good to me. > > When compiling, I got the following warnings: > > b/odp-util.c: In function ?odp_flow_key_from_flow__?: >

Re: [ovs-dev] [PATCH] Fix a bug in conversion between flow/mask and flow key

2013-08-29 Thread Andy Zhou
Good catch. The logic looks good to me. When compiling, I got the following warnings: b/odp-util.c: In function ‘odp_flow_key_from_flow__’: lib/odp-util.c:2559:17: error: comparison is always false due to limited range of data type [-Werror=type-limits] lib/odp-util.c:2560:31: error: comparison i