Re: [ovs-dev] [PATCH] Check disk space in ovs-bugtool

2013-09-24 Thread Ben Pfaff
On Tue, Sep 24, 2013 at 12:24:00PM -0700, Shih-Hao Li wrote: > Subject: [ovs-dev] [PATCH] Check disk space in ovs-bugtool We would usually write this as something like "ovs-bugtool: Limit disk usage." > Add a new command-line parameter to specify the maximum percentage > of free disk space allowe

Re: [ovs-dev] [PATCH] Check disk space in ovs-bugtool

2013-09-24 Thread Reid Price
It seems as though there might be use for a flag to allow using more of the disk somehow, or to tar up existing files rather than copying them. I assume in most cases the user can make that decision themselves by manually removing older files or other things on the FS. -Reid On Tue, Sep 24, 2

Re: [ovs-dev] [PATCH] Check disk space in ovs-bugtool

2013-09-24 Thread Ben Pfaff
On Tue, Sep 24, 2013 at 10:46:59AM -0700, Shih-Hao Li wrote: > > It might be worth documenting how to avoid the cap if the user really > > wants to (it looks like outputting to a fd instead of a file avoids > > it?). > > How about adding a new parameter, such as the percentage of free disk > space

Re: [ovs-dev] [PATCH] Check disk space in ovs-bugtool

2013-09-24 Thread Shih-Hao Li
Thanks for the review. Please see inline. Shih-Hao - Original Message - > From: "Ben Pfaff" > To: "Shih-Hao Li" > Cc: dev@openvswitch.org, "Shih-Hao Li" > Sent: Tuesday, September 24, 2013 9:58:16 AM > Subject: Re: [ovs-dev] [PATCH] Chec

Re: [ovs-dev] [PATCH] Check disk space in ovs-bugtool

2013-09-24 Thread Ben Pfaff
On Tue, Sep 24, 2013 at 09:37:18AM -0700, Shih-Hao Li wrote: > From: Shih-Hao Li > > When output to a file, only allow 90% of the free disk space to be used. This seems like a good idea. The code to check for free space and then subtract the amount used if it is allowable is repeated a couple o