Re: [ovs-dev] [PATCH] Add OpenFlow support for 802.1AD Ethertype

2014-10-23 Thread Thomas F Herbert
Thanks for your comments. On 10/18/14, 12:32 PM, Ben Pfaff wrote: On Sat, Oct 18, 2014 at 09:55:57AM -0400, Thomas F Herbert wrote: On 10/17/14, 4:54 PM, Ben Pfaff wrote: On Fri, Oct 17, 2014 at 01:19:33PM -0400, Dave Benson wrote: On Fri, Oct 10, 2014 at 6:43 PM, Ben Pfaff wrote: ... ...

Re: [ovs-dev] [PATCH] Add OpenFlow support for 802.1AD Ethertype

2014-10-18 Thread Ben Pfaff
On Sat, Oct 18, 2014 at 09:55:57AM -0400, Thomas F Herbert wrote: > On 10/17/14, 4:54 PM, Ben Pfaff wrote: > >On Fri, Oct 17, 2014 at 01:19:33PM -0400, Dave Benson wrote: > >>On Fri, Oct 10, 2014 at 6:43 PM, Ben Pfaff wrote: > >>... > > >My first thought is to define a new NXM_NX_VLAN_TPID that m

Re: [ovs-dev] [PATCH] Add OpenFlow support for 802.1AD Ethertype

2014-10-18 Thread Thomas F Herbert
On 10/17/14, 4:54 PM, Ben Pfaff wrote: On Fri, Oct 17, 2014 at 01:19:33PM -0400, Dave Benson wrote: On Fri, Oct 10, 2014 at 6:43 PM, Ben Pfaff wrote: ... My first thought is to define a new NXM_NX_VLAN_TPID that matches the TPID, and for backward compatibility to imply a match on 0x8100 if i

Re: [ovs-dev] [PATCH] Add OpenFlow support for 802.1AD Ethertype

2014-10-17 Thread Ben Pfaff
On Fri, Oct 17, 2014 at 01:19:33PM -0400, Dave Benson wrote: > On Fri, Oct 10, 2014 at 6:43 PM, Ben Pfaff wrote: > > With this change, I think that an OpenFlow flow table entry that > > matches on a VLAN will now match both 0x88a8 and 0x8100 tags for that > > VLAN. I doubt that that is desirable

Re: [ovs-dev] [PATCH] Add OpenFlow support for 802.1AD Ethertype

2014-10-17 Thread Dave Benson
Ben, Thanks for your thoughtful comments. Apologies for my late reply... Dave. On Fri, Oct 10, 2014 at 6:43 PM, Ben Pfaff wrote: > On Fri, Oct 10, 2014 at 10:06:29AM -0400, Dave Benson wrote: > > Previous behavior forced the use of the 802.1Q Ethertype for all VLAN > headers. > > In order to

Re: [ovs-dev] [PATCH] Add OpenFlow support for 802.1AD Ethertype

2014-10-16 Thread Thomas F Herbert
Ben, thanks for your comments on my comments. On 10/15/14, 5:08 PM, Ben Pfaff wrote: On Wed, Oct 15, 2014 at 06:14:16AM -0400, Thomas F Herbert wrote: I am late in commenting on Ben's comments on Dave's patch but I thought I would add my two cents. I need to review your patches, too, obviously

Re: [ovs-dev] [PATCH] Add OpenFlow support for 802.1AD Ethertype

2014-10-15 Thread Ben Pfaff
On Wed, Oct 15, 2014 at 06:14:16AM -0400, Thomas F Herbert wrote: > I am late in commenting on Ben's comments on Dave's patch but I > thought I would add my two cents. I need to review your patches, too, obviously. I'll try to do that soon. My guess is that your patches are more mature, because

Re: [ovs-dev] [PATCH] Add OpenFlow support for 802.1AD Ethertype

2014-10-15 Thread Thomas F Herbert
I am late in commenting on Ben's comments on Dave's patch but I thought I would add my two cents. On 10/10/14, 6:43 PM, Ben Pfaff wrote: On Fri, Oct 10, 2014 at 10:06:29AM -0400, Dave Benson wrote: One direction that we will probably have to take at some point is to allow matching and setting

Re: [ovs-dev] [PATCH] Add OpenFlow support for 802.1AD Ethertype

2014-10-10 Thread Ben Pfaff
On Fri, Oct 10, 2014 at 10:06:29AM -0400, Dave Benson wrote: > Previous behavior forced the use of the 802.1Q Ethertype for all VLAN headers. > In order to open the door for future support of VLAN stacking or Provider > Based > Bridging, support of the 802.1AD Ethertype is a logical first step. >