Re: [ovs-dev] new patch including code review comments

2012-03-26 Thread R.Kerur
Thanks Ben. Some of the changes were taken care but unfortunately missed to be included in the latest patch as it's a bit confusion to me right now which patch has what changes due to integration testing I do with vlan/vlan-qinq/mpls and I frequently rebase to latest. Patch with 2nd code review

Re: [ovs-dev] new patch including code review comments

2012-03-23 Thread Ben Pfaff
Thanks, Ravi. Here's some initial feedback. I didn't make it all the way through the patch yet. It applies, compiles, and passes "sparse" cleanly. Great! I don't see any handling for decrementing a TTL of 0. That's supposed to be sent to the controller with OFPR_INVALID_TTL. include/linux/op