Re: [ovs-dev] classifier versioning and rule_dpif_try_ref()

2015-08-02 Thread Ben Pfaff
On Sat, Aug 01, 2015 at 11:03:49AM -0700, Jarno Rajahalme wrote: > > > On Jul 31, 2015, at 21:54, Ben Pfaff wrote: > > > > Now that the classifier is versioned, is it still possible for > > rule_dpif_try_ref() to return false? Specifically, can we change the > > loop in rule_dpif_lookup_in_tabl

Re: [ovs-dev] classifier versioning and rule_dpif_try_ref()

2015-08-01 Thread Jarno Rajahalme
> On Jul 31, 2015, at 21:54, Ben Pfaff wrote: > > Now that the classifier is versioned, is it still possible for > rule_dpif_try_ref() to return false? Specifically, can we change the > loop in rule_dpif_lookup_in_table() to do an ordinary ref instead of a > try_ref? > > My motive is that, if

[ovs-dev] classifier versioning and rule_dpif_try_ref()

2015-07-31 Thread Ben Pfaff
Now that the classifier is versioned, is it still possible for rule_dpif_try_ref() to return false? Specifically, can we change the loop in rule_dpif_lookup_in_table() to do an ordinary ref instead of a try_ref? My motive is that, if we could change it, then we could drop the 'take_ref' parameter