Re: [ovs-dev] RFC: A plan for stats.

2014-09-20 Thread Daniele Di Proietto
On 9/20/14, 12:31 PM, "Ben Pfaff" wrote: >On Sat, Sep 20, 2014 at 07:23:30PM +, Daniele Di Proietto wrote: >> * Most importantly, many implementation of thread local storage (e.g. >> C11) do not allow cross-thread access (there?s a big comment in >> lib/ovs-thread.h). > >That's what the s

Re: [ovs-dev] RFC: A plan for stats.

2014-09-20 Thread Ben Pfaff
On Sat, Sep 20, 2014 at 07:23:30PM +, Daniele Di Proietto wrote: > * Most importantly, many implementation of thread local storage (e.g. > C11) do not allow cross-thread access (there?s a big comment in > lib/ovs-thread.h). That's what the standard says but I think that it is basically nonse

Re: [ovs-dev] RFC: A plan for stats.

2014-09-20 Thread Daniele Di Proietto
Hi Ethan, As you know I¹ve been working on similar problems for the userspace datapath. Also, I¹m about to post a patch series to reduce the overhead of counting (global, not per-flow) stats in dpif-netdev.c. Here are some thoughts : * I definitely think it¹s a good idea to use ovsthread_stats fo

[ovs-dev] RFC: A plan for stats.

2014-09-20 Thread Ethan Jackson
I'm doing some performance testing which heavily stresses the OVS DPDK slow path, and notice we spend a ridiculous amount of CPU time on the rule_dpif stats mutex. For my test case, by commenting out the mutex I literally doubled the performance. I'm in a bit of a rush, so as a short term hack, I