Re: [ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-06-24 Thread Ben Pfaff
Thanks. I played with this a little and sent out a patch documenting it: http://openvswitch.org/pipermail/dev/2014-June/041999.html On Mon, Jun 23, 2014 at 10:51:16PM +, Rogers, Gerald wrote: > Ben, > > I used the following indent options to format the file : > > indent -bad -bap -b

Re: [ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-06-23 Thread Rogers, Gerald
Ben, I used the following indent options to format the file : indent -bad -bap -bbb -br -blf -brs -cdw -ce -fca -i4 -l79 -lc79 -nbfda -nut -saf -sai -saw -sbi4 -sc -sob -st -cdb -pi4 Gerald On 5/7/14, 11:25 AM, "Ben Pfaff" wrote: >On Wed, May 07, 2014 at 11:21:37AM -0700, Pravin Shelar wrote

Re: [ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-05-07 Thread Ben Pfaff
On Wed, May 07, 2014 at 11:27:37AM -0700, Robert Love wrote: > I'm not sure what coding standard is followed in the ovs code base. > Is it the kernel's coding standard? No. See the CodingStyle file. It's basically BSD style with 4-space indents (not tabs). ___

Re: [ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-05-07 Thread Robert Love
On 05/07/2014 11:21 AM, Pravin Shelar wrote: On Wed, May 7, 2014 at 8:49 AM, Rogers, Gerald wrote: As for the formatting issues, is there a ³c² pretty print formatter I can run on ovs_client.c to make it conform to coding standards? I do not know such tool, I think you have to do it manually

Re: [ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-05-07 Thread Ben Pfaff
On Wed, May 07, 2014 at 11:21:37AM -0700, Pravin Shelar wrote: > On Wed, May 7, 2014 at 8:49 AM, Rogers, Gerald > wrote: > > As for the formatting issues, is there a ??c?? pretty print formatter I can > > run on ovs_client.c to make it conform to coding standards? > > I do not know such tool, I

Re: [ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-05-07 Thread Pravin Shelar
On Wed, May 7, 2014 at 8:49 AM, Rogers, Gerald wrote: > Pravin, > > On the 1GB page question. The patch simply allocates the rings and > creates a port. You can allocate more than a single 1 GB page, the > restriction is that it would need 1GB pages. The entire Huge Page > allocated by DPDK is

Re: [ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-05-07 Thread Rogers, Gerald
Pravin, On the 1GB page question. The patch simply allocates the rings and creates a port. You can allocate more than a single 1 GB page, the restriction is that it would need 1GB pages. The entire Huge Page allocated by DPDK is passed to each Virtual Machine, and all VM¹s share this memory. T

Re: [ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-05-06 Thread YAMAMOTO Takashi
> This patch enables the client dpdk rings within the netdev-dpdk. It adds > a new dpdk device called dpdkr (other naming suggestions?). how about dpdkring? YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listin

Re: [ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-05-06 Thread Pravin Shelar
Thanks for patch, It looks good, I have comments mostly related to coding style. Subject line should follow following format [PATCH /] : On Thu, May 1, 2014 at 3:58 AM, Gerald Rogers wrote: > This patch enables the client dpdk rings within the netdev-dpdk. It adds > a new dpdk device called dp

[ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-05-01 Thread Gerald Rogers
This patch enables the client dpdk rings within the netdev-dpdk. It adds a new dpdk device called dpdkr (other naming suggestions?). This allows for the use of shared memory to communicate with other dpdk applications, on the host or within a virtual machine. Instructions for use are in INSTA

Re: [ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-04-30 Thread Pravin Shelar
On Wed, Apr 30, 2014 at 1:01 PM, Rogers, Gerald wrote: > This patch enables the client dpdk rings within the netdev-dpdk. It adds > a new > dpdk device called dpdkr (other naming suggestions?). This allows for the > use > of shared memory to communicate with other dpdk applications, on the host

[ovs-dev] PATCH 1/1 : netdev-dpdk / add dpdk rings to netdev-dpdk

2014-04-30 Thread Rogers, Gerald
This patch enables the client dpdk rings within the netdev-dpdk. It adds a new dpdk device called dpdkr (other naming suggestions?). This allows for the use of shared memory to communicate with other dpdk applications, on the host or within a virtual machine. Instructions for use are in INSTALL.