On Wed, Mar 27, 2013 at 06:56:02PM -0700, Andy Zhou wrote:
> Thanks Ben for explaining. The patch looks good.
Thanks.
> If we skip 0s in flow_hash() as well, then miniflow_hash() can be made to
> produce the same value as flow_hash(), if at all useful.
I agree that it is possible. I do not kno
Thanks Ben for explaining. The patch looks good.
If we skip 0s in flow_hash() as well, then miniflow_hash() can be made to
produce the same value as flow_hash(), if at all useful.
Andy
On Wed, Mar 27, 2013 at 5:14 PM, Ben Pfaff wrote:
> On Wed, Mar 27, 2013 at 12:14:52PM -0700, Andy Zhou wro
On Wed, Mar 27, 2013 at 12:14:52PM -0700, Andy Zhou wrote:
> It would be nice to add a comment about what 'n' is.
>
> > +static void
> > +miniflow_init__(struct miniflow *dst, const struct flow *src, int n)
I added this comment:
/* Completes an initialization of 'dst' as a miniflow copy of 'src'
-- Forwarded message --
From: Andy Zhou
Date: Wed, Mar 27, 2013 at 12:14 PM
Subject: Re: [ovs-dev] [PATCH 1/3] match: New function
minimatch_matches_flow().
To: Ben Pfaff
Looks good. A few minor comments in-line:
On Tue, Mar 26, 2013 at 9:32 PM, Ben Pfaff wrote:
> Signed-off
