Re: [ovs-dev] ARP corner case in ovs_flow_extract()

2012-10-23 Thread Ben Pfaff
On Mon, Oct 22, 2012 at 02:10:57PM -0700, Ben Pfaff wrote: > There's a corner case in ovs_flow_extract() that seems a bit > troublesome. For an ARP with an opcode other than 1 or 2, we fill in > key->ip.proto with the opcode but we do not adjust key_len to include > the ARP info (so it won't get h

[ovs-dev] ARP corner case in ovs_flow_extract()

2012-10-22 Thread Ben Pfaff
There's a corner case in ovs_flow_extract() that seems a bit troublesome. For an ARP with an opcode other than 1 or 2, we fill in key->ip.proto with the opcode but we do not adjust key_len to include the ARP info (so it won't get hashed). However, in ovs_flow_to_nlattrs() we do include the opcode