Re: [ovs-dev] [xlate v2 4/6] ofproto-dpif: Move odp_actions from subfacet to facet.

2013-05-28 Thread Ethan Jackson
> There's something funny going on with rule_dpif_lookup() calls here. > handle_flow_miss() calls rule_dpif_lookup(). It only uses it in the > handle_flow_miss_without_facet() case, and only to pass it to > handle_flow_miss_without_facet(). In the > handle_flow_miss_with_facet() case, it still ca

Re: [ovs-dev] [xlate v2 4/6] ofproto-dpif: Move odp_actions from subfacet to facet.

2013-05-24 Thread Ben Pfaff
On Thu, May 23, 2013 at 05:15:18PM -0700, Ethan Jackson wrote: > Upon close inspection, it appears that it's not possible for > actions to differ between subfacets belonging to a given facet. > Given this fact, it makes sense to move datapath actions from > subfacets to their parent facets. It's b

[ovs-dev] [xlate v2 4/6] ofproto-dpif: Move odp_actions from subfacet to facet.

2013-05-23 Thread Ethan Jackson
Upon close inspection, it appears that it's not possible for actions to differ between subfacets belonging to a given facet. Given this fact, it makes sense to move datapath actions from subfacets to their parent facets. It's both conceptually more straightforward, and necessary for future threadi