Re: [ovs-dev] [xlate v2 3/6] ofproto: Ditch SLOW_IN_BAND slow path reason.

2013-05-28 Thread Ethan Jackson
>> subfacet_make_actions() was previously used such that it composed its >> actions into an on-stack buffer, then made a copy of that buffer into >> an exact-sized dynamically allocated buffer. Now, it uses a 0-sized >> dynamically allocated buffer. I think this will cause multiple >> realloc() c

Re: [ovs-dev] [xlate v2 3/6] ofproto: Ditch SLOW_IN_BAND slow path reason.

2013-05-24 Thread Ben Pfaff
On Fri, May 24, 2013 at 03:54:02PM -0700, Ben Pfaff wrote: > On Thu, May 23, 2013 at 05:15:17PM -0700, Ethan Jackson wrote: > > Before this patch, when in band control was enabled, every DHCP > > packet had to be sent to userspace to calculate it's actions. > > Those DHCP packets intended for the l

Re: [ovs-dev] [xlate v2 3/6] ofproto: Ditch SLOW_IN_BAND slow path reason.

2013-05-24 Thread Ben Pfaff
On Thu, May 23, 2013 at 05:15:17PM -0700, Ethan Jackson wrote: > Before this patch, when in band control was enabled, every DHCP > packet had to be sent to userspace to calculate it's actions. > Those DHCP packets intended for the local port would have a special > action added to ensure they actual

[ovs-dev] [xlate v2 3/6] ofproto: Ditch SLOW_IN_BAND slow path reason.

2013-05-23 Thread Ethan Jackson
Before this patch, when in band control was enabled, every DHCP packet had to be sent to userspace to calculate it's actions. Those DHCP packets intended for the local port would have a special action added to ensure they actually make it there. This unnecessarily complicates the code, so this pat