On Sat, May 25, 2013 at 03:44:39PM -0500, Ethan Jackson wrote:
> > I think the "if" test here cannot ever be true, because the loop
> > un-set all of the bits in 'slow'. (I think that this was also the
> > case before the patch.) Perhaps we should just delete it.
>
> I've removed it from the pat
> I think the "if" test here cannot ever be true, because the loop
> un-set all of the bits in 'slow'. (I think that this was also the
> case before the patch.) Perhaps we should just delete it.
I've removed it from the patch. Looks good otherwise?
Ethan
___
On Thu, May 23, 2013 at 05:15:16PM -0700, Ethan Jackson wrote:
> Before this patch, datapath keys with ODP_FIT_TO_LITTLE, would be
> assigned subfacets and installed in the kernel with a SLOW_MATCH
> slow path reason. This is problematic, because these flow keys
> can't be reliable converted into
Before this patch, datapath keys with ODP_FIT_TO_LITTLE, would be
assigned subfacets and installed in the kernel with a SLOW_MATCH
slow path reason. This is problematic, because these flow keys
can't be reliable converted into a 'struct flow' thus breaking a
fundamental assumption of ofproto-dpif.
