Re: [ovs-dev] [xlate v1 17/18] tunnel: Hide 'struct tnl_port' internally.

2013-06-28 Thread Ethan Jackson
> I'm not really happy with adding another hash lookup along this path, > but we can deal with that in profiling later. It's just a pointer hash, so I doubt it will matter, but if it does we can always pass it as an argument to tnl_port_send(). It's caller could cash it trivially. Thanks for the

Re: [ovs-dev] [xlate v1 17/18] tunnel: Hide 'struct tnl_port' internally.

2013-06-26 Thread Ben Pfaff
On Mon, Jun 24, 2013 at 06:59:31PM -0700, Ethan Jackson wrote: > This simplifies the tunnel module's interface and prevents us from > having to sync 'struct tnl_port' once ofproto-dpif and > ofproto-dpif-xlate are disentangled. > > Signed-off-by: Ethan Jackson With this and the previous patch, i

[ovs-dev] [xlate v1 17/18] tunnel: Hide 'struct tnl_port' internally.

2013-06-24 Thread Ethan Jackson
This simplifies the tunnel module's interface and prevents us from having to sync 'struct tnl_port' once ofproto-dpif and ofproto-dpif-xlate are disentangled. Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif-xlate.c |4 +-- ofproto/ofproto-dpif.c | 26 +++ ofproto/of