Re: [ovs-dev] [valgrind 3/5] flow: Fix use-after-free in flow_compose().

2014-06-05 Thread Ben Pfaff
On Thu, Jun 05, 2014 at 10:34:38AM -0700, Andy Zhou wrote: > On Wed, Jun 4, 2014 at 5:07 PM, Ben Pfaff wrote: > > flow_compose_l4() can cause 'b' to be reallocated, thus the network header > > pointer needs to be refreshed afterward. > > > > Found by valgrind in the IPv6 case. I updated the IPv4

Re: [ovs-dev] [valgrind 3/5] flow: Fix use-after-free in flow_compose().

2014-06-05 Thread Andy Zhou
On Wed, Jun 4, 2014 at 5:07 PM, Ben Pfaff wrote: > flow_compose_l4() can cause 'b' to be reallocated, thus the network header > pointer needs to be refreshed afterward. > > Found by valgrind in the IPv6 case. I updated the IPv4 case too just in > case, and for consistency. > > Signed-off-by: Ben

[ovs-dev] [valgrind 3/5] flow: Fix use-after-free in flow_compose().

2014-06-04 Thread Ben Pfaff
flow_compose_l4() can cause 'b' to be reallocated, thus the network header pointer needs to be refreshed afterward. Found by valgrind in the IPv6 case. I updated the IPv4 case too just in case, and for consistency. Signed-off-by: Ben Pfaff --- lib/flow.c |2 ++ 1 file changed, 2 insertions