Re: [ovs-dev] [v2] datapath: Distinguish between nested and variable length attributes

2014-08-12 Thread Daniele Di Proietto
Hi Andy, Two comments inline Other than those, LGTM, but review by others might be useful :) Acked-by: Daniele Di Proietto On 8/12/14, 1:45 PM, "Andy Zhou" wrote: >-1 was used to indicate both nested and variable length attributes. >This patch introduces OVS_KEY_LEN_NESTED and OVS_KEY_LEN_V

[ovs-dev] [v2] datapath: Distinguish between nested and variable length attributes

2014-08-12 Thread Andy Zhou
-1 was used to indicate both nested and variable length attributes. This patch introduces OVS_KEY_LEN_NESTED and OVS_KEY_LEN_VARIABLE to tell them apart. Refactor nlattr_set() to more more generally all ovs netlink key attributes. Signed-off-by: Andy Zhou --- datapath/flow_netlink.c | 88 ++