Re: [ovs-dev] [tos 2/3] ofproto-dpif: Simplify commit logic.

2011-11-23 Thread Ethan Jackson
> We could now shorten ofproto.c a bit by moving commit_odp_actions() > and all of its helpers to odp-util.c. I'll make a note to do this after I've merged the series. Ethan ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinf

Re: [ovs-dev] [tos 2/3] ofproto-dpif: Simplify commit logic.

2011-11-23 Thread Ben Pfaff
On Tue, Nov 22, 2011 at 04:29:35PM -0800, Ethan Jackson wrote: > Before executing an output action, ofproto-dpif must commit the > changes it's made to the flow so they are reflected in the > packet. This code has been unnecessarily complex. This patch > attempts to simplify the code in the follo

[ovs-dev] [tos 2/3] ofproto-dpif: Simplify commit logic.

2011-11-22 Thread Ethan Jackson
Before executing an output action, ofproto-dpif must commit the changes it's made to the flow so they are reflected in the packet. This code has been unnecessarily complex. This patch attempts to simplify the code in the following ways. - Commit in fewer places. In an attempt to provide some opt