Re: [ovs-dev] [threads v2] ofp-print: Avoid returning static data.

2013-06-12 Thread Ben Pfaff
Done, and pushed. On Wed, Jun 12, 2013 at 02:48:41PM -0700, Justin Pettit wrote: > Looks good, but I think similar changes should be made to > ofp_port_reason_to_string() and OFP_PORT_REASON_BUFSIZE. > > --Justin > > > On Jun 12, 2013, at 2:45 PM, Ben Pfaff wrote: > > > Returning a static dat

Re: [ovs-dev] [threads v2] ofp-print: Avoid returning static data.

2013-06-12 Thread Justin Pettit
Looks good, but I think similar changes should be made to ofp_port_reason_to_string() and OFP_PORT_REASON_BUFSIZE. --Justin On Jun 12, 2013, at 2:45 PM, Ben Pfaff wrote: > Returning a static data buffer makes code more brittle and definitely > not thread-safe, so this commit switches to using

[ovs-dev] [threads v2] ofp-print: Avoid returning static data.

2013-06-12 Thread Ben Pfaff
Returning a static data buffer makes code more brittle and definitely not thread-safe, so this commit switches to using a caller-provided buffer instead. Signed-off-by: Ben Pfaff --- lib/ofp-print.c | 47 --- 1 files changed, 32 insertions(+), 15 del