Re: [ovs-dev] [threads 08/23] dirs: Make thread-safe.

2013-07-22 Thread Ben Pfaff
Yes. On Mon, Jul 22, 2013 at 10:25:09AM -0700, Alex Wang wrote: > Seems I understand now, > > Is that for directing all error messages to corresponding lines in > "lib/dirs.c.in"? > > > On Mon, Jul 22, 2013 at 10:20 AM, Alex Wang wrote: > > > Looks good to me, > > > > One question, why do we

Re: [ovs-dev] [threads 08/23] dirs: Make thread-safe.

2013-07-22 Thread Alex Wang
Thanks Ben for the explanation, On Mon, Jul 22, 2013 at 10:37 AM, Ben Pfaff wrote: > Yes. > > On Mon, Jul 22, 2013 at 10:25:09AM -0700, Alex Wang wrote: > > Seems I understand now, > > > > Is that for directing all error messages to corresponding lines in > > "lib/dirs.c.in"? > > > > > > On Mon

Re: [ovs-dev] [threads 08/23] dirs: Make thread-safe.

2013-07-22 Thread Ben Pfaff
On Mon, Jul 22, 2013 at 10:20:54AM -0700, Alex Wang wrote: > One question, why do we have the "#line directive" in "lib/dirs.c.in"? > We have already created "dirs.c" in "lib/automake.mk". What is the > use of "#line directive" here? dirs.c gets generated by search-and-replace on dirs.c.in. If th

Re: [ovs-dev] [threads 08/23] dirs: Make thread-safe.

2013-07-22 Thread Alex Wang
Seems I understand now, Is that for directing all error messages to corresponding lines in "lib/dirs.c.in"? On Mon, Jul 22, 2013 at 10:20 AM, Alex Wang wrote: > Looks good to me, > > One question, why do we have the "#line directive" in "lib/dirs.c.in"? > We have already created "dirs.c" in "l

Re: [ovs-dev] [threads 08/23] dirs: Make thread-safe.

2013-07-22 Thread Alex Wang
Looks good to me, One question, why do we have the "#line directive" in "lib/dirs.c.in"? We have already created "dirs.c" in "lib/automake.mk". What is the use of "#line directive" here? Thanks, On Thu, Jul 18, 2013 at 4:15 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/dirs.c

[ovs-dev] [threads 08/23] dirs: Make thread-safe.

2013-07-18 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/dirs.c.in | 37 + 1 files changed, 29 insertions(+), 8 deletions(-) diff --git a/lib/dirs.c.in b/lib/dirs.c.in index 658a74b..85c49ee 100644 --- a/lib/dirs.c.in +++ b/lib/dirs.c.in @@ -1,6 +1,6 @@ #line 2 "@srcdir@/lib/dirs.