Re: [ovs-dev] [threaded-put 05/21] ofproto: Simplify thread creation API.

2013-12-12 Thread Ben Pfaff
I really just want an update to the commit message. On Dec 12, 2013 4:51 PM, "Ethan Jackson" wrote: > > It seems harmless but the reason for it isn't really obvious. Maybe > > this is to support some later change in the series? If so then it would > > be nice to hint at that in the commit messa

Re: [ovs-dev] [threaded-put 05/21] ofproto: Simplify thread creation API.

2013-12-12 Thread Ethan Jackson
> It seems harmless but the reason for it isn't really obvious. Maybe > this is to support some later change in the series? If so then it would > be nice to hint at that in the commit message. The main reason is that the API became a bit unwieldy once there were two types of thread to deal with.

Re: [ovs-dev] [threaded-put 05/21] ofproto: Simplify thread creation API.

2013-12-12 Thread Ben Pfaff
On Sun, Dec 08, 2013 at 06:45:11PM -0800, Ethan Jackson wrote: > There's no particular reason for the function controlling the number > of threads to be bound up with dpif_recv_set(). This patch breaks > them up, but as a side effect means threads will run doing nothing > when datapath upcall rece

[ovs-dev] [threaded-put 05/21] ofproto: Simplify thread creation API.

2013-12-08 Thread Ethan Jackson
There's no particular reason for the function controlling the number of threads to be bound up with dpif_recv_set(). This patch breaks them up, but as a side effect means threads will run doing nothing when datapath upcall receiving is disabled. Signed-off-by: Ethan Jackson --- ofproto/ofproto-