Re: [ovs-dev] [thread-safety 05/11] bfd: Make the BFD module thread safe.

2013-08-01 Thread Ben Pfaff
On Tue, Jul 30, 2013 at 04:02:05PM -0700, Ethan Jackson wrote: > There was actually a second potential deadlock. I fixed both of them and > systematically annotated the functions, hopefully preventing the problem in > the > future. Thanks for fixing these. I only skimmed the incremental, but: A

Re: [ovs-dev] [thread-safety 05/11] bfd: Make the BFD module thread safe.

2013-07-30 Thread Ethan Jackson
There was actually a second potential deadlock. I fixed both of them and systematically annotated the functions, hopefully preventing the problem in the future. --- lib/bfd.c | 66 +++-- 1 file changed, 38 insertions(+), 28 deletions(-)

Re: [ovs-dev] [thread-safety 05/11] bfd: Make the BFD module thread safe.

2013-07-29 Thread Ben Pfaff
On Fri, Jul 26, 2013 at 06:07:06PM -0700, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson I believe that bfd_get_status() has a deadlock because it calls bfd_forwarding() which also takes the lock. Otherwise: Acked-by: Ben Pfaff ___ dev mailing l

[ovs-dev] [thread-safety 05/11] bfd: Make the BFD module thread safe.

2013-07-26 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- lib/bfd.c | 166 - 1 file changed, 109 insertions(+), 57 deletions(-) diff --git a/lib/bfd.c b/lib/bfd.c index 3ac257a..054a6ae 100644 --- a/lib/bfd.c +++ b/lib/bfd.c @@ -28,6 +28,7 @@ #include "netlin