Re: [ovs-dev] [rule evict v2] ofproto-dpif: Lock rules to prevent eviction.

2013-08-12 Thread Ethan Jackson
At any rate this isn't an issue. I have simply unlocked and destroyed the rule after it's been removed from the classifier. Ethan On Tue, Aug 13, 2013 at 7:48 AM, Ben Pfaff wrote: > On Mon, Aug 12, 2013 at 01:23:38PM +0900, YAMAMOTO Takashi wrote: >> > This patch uses a read-write lock to preve

Re: [ovs-dev] [rule evict v2] ofproto-dpif: Lock rules to prevent eviction.

2013-08-12 Thread Ben Pfaff
On Mon, Aug 12, 2013 at 01:23:38PM +0900, YAMAMOTO Takashi wrote: > > This patch uses a read-write lock to prevent rules from being evicted > > while they're used by child threads. It also changes the prototypes > > of the various rule lookup functions so that the thread safety > > analysis can be

Re: [ovs-dev] [rule evict v2] ofproto-dpif: Lock rules to prevent eviction.

2013-08-11 Thread YAMAMOTO Takashi
> This patch uses a read-write lock to prevent rules from being evicted > while they're used by child threads. It also changes the prototypes > of the various rule lookup functions so that the thread safety > analysis can be used to ensure that the locking is handled properly. destroying a rwlock

Re: [ovs-dev] [rule evict v2] ofproto-dpif: Lock rules to prevent eviction.

2013-08-11 Thread Ethan Jackson
> I'm a little worried about deadlocks. There are lots of corner cases > here (eviction, in-band control, fail-open) and I'm concerned that we > don't hit those much in testing. Agreed. Not much to do but jump in the deep end. Thanks for the reviews. Ethan X-CudaMail-Whitelist-To: dev@openvswi

Re: [ovs-dev] [rule evict v2] ofproto-dpif: Lock rules to prevent eviction.

2013-08-11 Thread Ben Pfaff
On Fri, Aug 09, 2013 at 02:05:59PM -0700, Ethan Jackson wrote: > This patch uses a read-write lock to prevent rules from being evicted > while they're used by child threads. It also changes the prototypes > of the various rule lookup functions so that the thread safety > analysis can be used to en

[ovs-dev] [rule evict v2] ofproto-dpif: Lock rules to prevent eviction.

2013-08-09 Thread Ethan Jackson
This patch uses a read-write lock to prevent rules from being evicted while they're used by child threads. It also changes the prototypes of the various rule lookup functions so that the thread safety analysis can be used to ensure that the locking is handled properly. Signed-off-by: Ethan Jackso