Thx for the review, Jarno,
I find it conceivable that post recirculation flows would be able to cross
> a later patch port in the pipeline. Therefore, rather than stating that
> “post recirculation flows are not allowed to cross a patch port”, I think
> we should say that recirculated flows must b
Assuming the notes below are addressed:
Acked-by: Jarno Rajahalme
On Dec 21, 2014, at 9:58 AM, Alex Wang wrote:
> After commit 0c7812e5e (recirculation: Do not drop packet when
> there is no match from internal table.), if flow keys are modified
> before the recirculation action (e.g. set vlan
Thx for the review,
Forgot to mention, that I'll add (both in code and in commit log) that this
will not fix the case where the recv_bridge is not the same as
recirc_bridge, and rules matching in_port are installed on recirc_bridge.
(since in that case, the in_port is set to OFPP_NONE)
Thanks,
Al
Acked-by: Andy Zhou
On Sun, Dec 21, 2014 at 9:58 AM, Alex Wang wrote:
> After commit 0c7812e5e (recirculation: Do not drop packet when
> there is no match from internal table.), if flow keys are modified
> before the recirculation action (e.g. set vlan ID), the miss
> handling of recirc'ed packe
After commit 0c7812e5e (recirculation: Do not drop packet when
there is no match from internal table.), if flow keys are modified
before the recirculation action (e.g. set vlan ID), the miss
handling of recirc'ed packets may not reach the intended
'ofproto_dpif' which has rules looking up the 'reci
