Re: [ovs-dev] [packet_in 10/13] ofputil: New function ofputil_decode_packet_in().

2012-01-03 Thread Ben Pfaff
On Tue, Jan 03, 2012 at 12:13:33PM -0600, Ethan Jackson wrote: > > One comment: other ofputil_decode_*() functions call > > ofputil_decode_msg_type() and check the result because they can actually > > decode more than one message format. ?But this function only decodes a > > single message format,

Re: [ovs-dev] [packet_in 10/13] ofputil: New function ofputil_decode_packet_in().

2012-01-03 Thread Ethan Jackson
> One comment: other ofputil_decode_*() functions call > ofputil_decode_msg_type() and check the result because they can actually > decode more than one message format.  But this function only decodes a > single message format, so I think that it is better for it to simply > assume that the caller

Re: [ovs-dev] [packet_in 10/13] ofputil: New function ofputil_decode_packet_in().

2011-12-29 Thread Ben Pfaff
This is the direction that I want to move in anyhow, for supporting OpenFlow 1.1 and later. Thanks for doing this. One comment: other ofputil_decode_*() functions call ofputil_decode_msg_type() and check the result because they can actually decode more than one message format. But this function

[ovs-dev] [packet_in 10/13] ofputil: New function ofputil_decode_packet_in().

2011-12-28 Thread Ethan Jackson
--- lib/ofp-print.c| 39 +++ lib/ofp-util.c | 28 lib/ofp-util.h |3 +++ ofproto/ofproto-dpif.c |2 ++ 4 files changed, 56 insertions(+), 16 deletions(-) diff --git a/lib/ofp-print.c b/lib/ofp-pri