Re: [ovs-dev] [ovn-ipv6 16/26] packets: Cleanup ND compose functions.

2016-07-22 Thread Justin Pettit
> On Jul 13, 2016, at 12:36 PM, Ben Pfaff wrote: > > On Tue, Jul 12, 2016 at 07:26:29PM +0800, Zong Kai Li wrote: >> On Tue, Jul 12, 2016 at 2:56 PM, Justin Pettit wrote: >>> Rename "compose_nd" and "compose_na" to "compose_nd_sol" and >>> "compose_nd_adv", respecively, to be clearer about thei

Re: [ovs-dev] [ovn-ipv6 16/26] packets: Cleanup ND compose functions.

2016-07-13 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 11:56:46PM -0700, Justin Pettit wrote: > Rename "compose_nd" and "compose_na" to "compose_nd_sol" and > "compose_nd_adv", respecively, to be clearer about their functionality. > Also change the source and destination IPv6 addresses to take > "struct in6_addr" arguments, whic

Re: [ovs-dev] [ovn-ipv6 16/26] packets: Cleanup ND compose functions.

2016-07-13 Thread Ben Pfaff
On Tue, Jul 12, 2016 at 07:26:29PM +0800, Zong Kai Li wrote: > On Tue, Jul 12, 2016 at 2:56 PM, Justin Pettit wrote: > > Rename "compose_nd" and "compose_na" to "compose_nd_sol" and > > "compose_nd_adv", respecively, to be clearer about their functionality. > > Also change the source and destinati

Re: [ovs-dev] [ovn-ipv6 16/26] packets: Cleanup ND compose functions.

2016-07-12 Thread Zong Kai Li
On Tue, Jul 12, 2016 at 2:56 PM, Justin Pettit wrote: > Rename "compose_nd" and "compose_na" to "compose_nd_sol" and > "compose_nd_adv", respecively, to be clearer about their functionality. > Also change the source and destination IPv6 addresses to take > "struct in6_addr" arguments, which are mo

[ovs-dev] [ovn-ipv6 16/26] packets: Cleanup ND compose functions.

2016-07-12 Thread Justin Pettit
Rename "compose_nd" and "compose_na" to "compose_nd_sol" and "compose_nd_adv", respecively, to be clearer about their functionality. Also change the source and destination IPv6 addresses to take "struct in6_addr" arguments, which are more common in the code base. Signed-off-by: Justin Pettit ---