Re: [ovs-dev] [netdev-linux]Deadlock is fixed; netdev_open() has a bug

2013-08-10 Thread Ben Pfaff
On Sun, Aug 11, 2013 at 11:30:10AM +0800, ZhengLingyun wrote: > netdev_open does shash_add() but no shash_delete() when error > occurs, such as device not exists. It will cause a SIGSEGV signal. Thanks for the report. I sent out a fix: http://openvswitch.org/pipermail/dev/2013-August/0305

Re: [ovs-dev] [netdev-linux]Deadlock is fixed; netdev_open() has a bug

2013-08-10 Thread ZhengLingyun
It is ok now. Another problem: netdev_open does shash_add() but no shash_delete() when error occurs, such as device not exists. It will cause a SIGSEGV signal. At 2013-08-10 21:49:30,"Ben Pfaff" wrote: >On Sat, Aug 10, 2013 at 06:33:35PM +0800, ZhengLingyun wrote: >> I just update the code.

Re: [ovs-dev] [netdev-linux]Deadlock

2013-08-10 Thread Ben Pfaff
On Sat, Aug 10, 2013 at 06:33:35PM +0800, ZhengLingyun wrote: > I just update the code. It can't run (just in userspace?). > There is a recursive dead lock in netdev_linux_set_etheraddr and > netdev_linux_update_flags. Thank you for the report. You are right, this is most likely to affect the us

[ovs-dev] [netdev-linux]Deadlock

2013-08-10 Thread ZhengLingyun
Hi, Ben I just update the code. It can't run (just in userspace?). There is a recursive dead lock in netdev_linux_set_etheraddr and netdev_linux_update_flags. #0 0xb7fdd424 in __kernel_vsyscall () #1 0xb7dbe5a2 in __lll_lock_wait () from /lib/i386-linux-gnu/libpthread.so.0 #2 0xb7db9ead in _L