Re: [ovs-dev] [murmurhash 4/4] hash: Replace primary hash functions by murmurhash.

2013-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2013 at 02:24:56PM -0800, Ethan Jackson wrote: > I might consider putting hash_3words() near hash_2words() in the > header file. Mostly just for consistency sake. I put the prototypes nearby at the top of the file, but hash_3words() generated enough code that it didn't look worthw

Re: [ovs-dev] [murmurhash 4/4] hash: Replace primary hash functions by murmurhash.

2013-01-16 Thread Ethan Jackson
I might consider putting hash_3words() near hash_2words() in the header file. Mostly just for consistency sake. In hash_3words(), you're finishing with a byte count of 8 instead 12. I may be misinterpreting what that value is for though. Acked-by: Ethan Jackson On Fri, Dec 14, 2012 at 4:33 PM

[ovs-dev] [murmurhash 4/4] hash: Replace primary hash functions by murmurhash.

2012-12-14 Thread Ben Pfaff
murmurhash is faster than Jenkins and slightly higher quality, so switch to it for hashing words. The best timings I got for hashing for data lengths of the following numbers of 32-bit words, in seconds per 1,000,000,000 hashes, were: words murmurhash Jenkins hash - --